commit aae2d2d3ae271f61c7523dc19ab336e084639355
parent 0c7b1e586f357f47d72d06d12437549f6a675706
Author: Matsuda Kenji <info@mtkn.jp>
Date: Tue, 19 Dec 2023 14:54:36 +0900
delete unused items
Diffstat:
3 files changed, 1 insertion(+), 38 deletions(-)
diff --git a/file.go b/file.go
@@ -26,12 +26,6 @@ type WriterStatFile interface {
WStat(stat *Stat) error
}
-// TODO: I think Remove should be implemented by the FS's method.
-type RemoverFile interface {
- File
- Remove() error
-}
-
// ReadDirFile is a directory.
// Note that non-directory file can implement this. In this case, ReadDir should
// return an error.
diff --git a/fs.go b/fs.go
@@ -1,9 +1,7 @@
package lib9p
import (
- "fmt"
"io/fs"
- "path"
)
// FS is an file system to be exported by 9P server.
@@ -25,35 +23,6 @@ type RemoverFS interface {
Remove(name string) error
}
-// getChildren returns the child files in the directory specified by dirpath.
-func getChildren(fsys FS, dirpath string) ([]File, error) {
- dir0, err := fsys.OpenFile(dirpath, OREAD)
- if err != nil {
- return nil, fmt.Errorf("open dir: %v", err)
- }
- defer dir0.Close()
- dir, ok := dir0.(ReadDirFile)
- if !ok {
- return nil, fmt.Errorf("not a directory")
- }
- des, err := dir.ReadDir(-1)
- if err != nil {
- return nil, fmt.Errorf("readdir: %v", err)
- }
- children := make([]File, len(des))
- for i, de := range des {
- f, err := fsys.OpenFile(path.Join(dirpath, de.Name()), OREAD)
- if err != nil {
- for j := 0; j < i; j++ {
- children[j].Close()
- }
- return nil, fmt.Errorf("open child: %v", err)
- }
- children[i] = f
- }
- return children, nil
-}
-
func FSModeToQidType(fm fs.FileMode) QidType {
var qt QidType
if fm&fs.ModeDir != 0 {
diff --git a/server.go b/server.go
@@ -881,7 +881,7 @@ func sWStat(ctx context.Context, s *Server, r *Req) {
newStat.Mtime = wstat.Mtime
}
// TODO: check group membership
- // now group member == group leader == gid
+ // for now, group member == group leader == gid
if wstat.Gid != "" && wstat.Gid != newStat.Gid {
// by the owner if also a member of the new group;
// or by the group leader of the file's current group if
